From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: pci: implement Sync for Device Date: Mon, 18 May 2026 16:24:33 +1000 Message-ID: In-Reply-To: <20260517000149.3226762-6-dakr@kernel.org> References: <20260517000149.3226762-1-dakr@kernel.org> <20260517000149.3226762-6-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```rust +// SAFETY: `Device` is a transparent wrapper around `Device` which = is already `Send + Sync`. +// Being `Bound` does not add any state that would make it not `Sync`. +unsafe impl Sync for Device {} ``` Necessary because `Bound` contains `PhantomData<*mut ()>` (to prevent `Send= `/`Sync` auto-impl), but `Device` should still be `Sync` since the u= nderlying `Device` is. The safety reasoning is sound =E2=80=94 `Bound` is a= zero-sized marker that doesn't affect thread safety of the wrapped device. ### PATCHES 6-8: pci/platform/auxiliary Device: implement Sync Same pattern as patch 5, applied to bus-specific device wrappers. Each foll= ows the same reasoning: ```rust +unsafe impl Sync for Device {} ``` All correct =E2=80=94 these are transparent wrappers around the base `Devic= e` which was made `Sync` in patch 5. --- Generated by Claude Code Patch Reviewer