From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Add Cadence MHDP8501 Date: Mon, 25 May 2026 22:48:49 +1000 Message-ID: In-Reply-To: <20260519-dcss-hdmi-upstreaming-v23-5-5615524a9c63@oss.nxp.com> References: <20260519-dcss-hdmi-upstreaming-v23-0-5615524a9c63@oss.nxp.com> <20260519-dcss-hdmi-upstreaming-v23-5-5615524a9c63@oss.nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The binding splits the compatible into `fsl,imx8mq-mhdp8501-hdmi` and `fsl,= imx8mq-mhdp8501-dp`, which is the correct approach (bridge type from DT rat= her than auto-detection). **Issue:** 1. **`port@1` requires `data-lanes`**: The binding makes `data-lanes` requi= red in port@1's endpoint. But the cover letter says port@1 was removed from= the dtsi to avoid dtbs_check failures for boards that include the dtsi wit= hout setting data-lanes. This creates an inconsistency: the binding says po= rt@1 is required (under `ports`), but the dtsi doesn't include it. Boards m= ust add port@1 themselves =E2=80=94 this is documented but could be error-p= rone. --- Generated by Claude Code Patch Reviewer