From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sti: hdmi: Use the common TMDS char rate constants
Date: Mon, 25 May 2026 22:44:50 +1000
Message-ID: <review-patch5-20260519144712.1418302-6-javierm@redhat.com>
In-Reply-To: <20260519144712.1418302-6-javierm@redhat.com>
References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-6-javierm@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Replaces two magic numbers in `sti_hdmi_tx3g4c28phy.c`:
- `340000000` =E2=86=92 `DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3`
- `165000000` =E2=86=92 `DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0`

Adds the necessary `#include <drm/display/drm_hdmi_helper.h>`. Both values =
are exact matches. Note that there's also a `340000000` in the `pll_mode` t=
able on line 60 (`{170000000, 340000000, 16, ODF_DIV_1}`), but that's table=
 data representing a range boundary, not a named threshold check, so leavin=
g it as a literal is reasonable.

**No issues.**

---

---
Generated by Claude Code Patch Reviewer