From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: Add support for RZ/T2H SoC
Date: Mon, 25 May 2026 22:39:45 +1000
Message-ID: <review-patch5-20260519160825.4082566-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20260519160825.4082566-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
References: <20260519160825.4082566-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260519160825.4082566-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Good**

Adds the actual RZ/T2H support. Key additions:

1. **Feature flag infrastructure** =E2=80=94 `RZG2L_DU_FEATURE_DPIO_OE` and=
 the `rzg2l_du_has()` helper. The helper is clean:
```c
static inline bool rzg2l_du_has(struct rzg2l_du_device *rcdu,
                unsigned int feature)
{
    return rcdu->info->features & feature;
}
```

2. **DPI output enable** =E2=80=94 In `rzg2l_du_start_stop()`, the RZ/T2H v=
ariant additionally asserts `DU_MCR0_DPI_EN` (BIT(0)):
```c
u32 val =3D DU_MCR0_DI_EN;

if (start && rzg2l_du_has(rcdu, RZG2L_DU_FEATURE_DPIO_OE))
    val |=3D DU_MCR0_DPI_EN;

writel(start ? val : 0, rcdu->mmio + DU_MCR0);
```

This correctly only sets `DPI_EN` when starting, and writes 0 when stopping=
 (clearing both bits).

3. **Device info** for the new SoC with clock limits 5000=E2=80=93100000 kH=
z (wider than RZ/G2UL/G2L).

The `features` field is added to the struct doc comment in `rzg2l_du_drv.h`=
, which is good.

One thing to note: the patch series does not add the `r9a09g087` (RZ/N2H) c=
ompatible to the `of_device_id` table in the driver. This is fine since the=
 DT binding specifies `renesas,r9a09g077-du` as the fallback for RZ/N2H, so=
 the kernel will match on the RZ/T2H compatible. This is the standard Renes=
as pattern for compatible SoC variants.

**Overall verdict: The series looks ready to merge.** It's well-reviewed, f=
ollows established patterns, and the changes are correct and minimal.

---
Generated by Claude Code Patch Reviewer