From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi_state_helper: Add ctx-aware hotplug helper for SCDC sync Date: Mon, 25 May 2026 21:15:03 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-5-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-5-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The approach of adding a `_ctx` variant alongside the existing context-free= `drm_atomic_helper_connector_hdmi_hotplug()` is clean. The function signat= ure change of `drm_atomic_helper_connector_hdmi_update()` from `void` to `i= nt` is well-motivated. One observation: on the disconnect path, `drm_scdc_sync_status(connector, f= alse, ctx)` is called, but its return value is ignored. This is deliberate = =E2=80=94 on disconnect, there's nothing to recover, and the function curre= ntly returns 0 for the unplug case anyway. Fine. --- Generated by Claude Code Patch Reviewer