From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sti: hdmi: Use the common TMDS char rate constants
Date: Mon, 25 May 2026 21:45:02 +1000
Message-ID: <review-patch5-20260520144424.1633354-6-javierm@redhat.com>
In-Reply-To: <20260520144424.1633354-6-javierm@redhat.com>
References: <20260520144424.1633354-1-javierm@redhat.com> <20260520144424.1633354-6-javierm@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Replaces two magic numbers: 340000000 and 165000000 with `HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ` and `HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ` respectively. Correctly adds `#include <linux/hdmi.h>` since this file didn't have it (directly or transitively before this patch -- wait, actually `sti_hdmi_tx3g4c28phy.h` might pull it in, but adding the explicit include is the right practice).

```c
+#include <linux/hdmi.h>
+
 #include <drm/drm_print.h>
```

No issues. The include ordering (linux/ before drm/) is correct.

---
Generated by Claude Code Patch Reviewer