From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: miscdevice: set fops.owner from driver module pointer Date: Mon, 25 May 2026 20:45:44 +1000 Message-ID: In-Reply-To: <20260521-fix-fops-owner-v2-5-fd99079c5a04@linux.dev> References: <20260521-fix-fops-owner-v2-0-fd99079c5a04@linux.dev> <20260521-fix-fops-owner-v2-5-fd99079c5a04@linux.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Sets `owner` in the miscdevice fops vtable: ```rust owner: ::THIS_MODULE.as_ptr(), ``` Added `ModuleMetadata` to the imports. **Observations:** 1. Same pattern as the DRM fix. `MiscDevice` also has `#[vtable]`, so `T::ThisModule` is available. 2. The `..pin_init::zeroed()` struct tail fill ensures other fields remain zero-initialized, and `owner` is now correctly set before that. **No issues found.** This is the critical fix for miscdevice. --- Generated by Claude Code Patch Reviewer