From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: glymur: Add GPU cooling Date: Mon, 25 May 2026 18:58:51 +1000 Message-ID: In-Reply-To: <20260522-glymur-gpu-dt-v5-5-562c406b210c@oss.qualcomm.com> References: <20260522-glymur-gpu-dt-v5-0-562c406b210c@oss.qualcomm.com> <20260522-glymur-gpu-dt-v5-5-562c406b210c@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Summary:** Converts all 14 GPU thermal zones from stub "hot" trip points = at 90=C2=B0C to active "passive" cooling at 95=C2=B0C with 1=C2=B0C hystere= sis and 100ms polling, all referencing the GPU device as a cooling device. The changes are mechanically consistent across all 14 zones: - Adds `polling-delay-passive =3D <100>` for 100ms polling during thermal m= itigation. - Adds `cooling-maps` referencing `<&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>= `. - Changes trip type from `"hot"` to `"passive"` to enable kernel-driven fre= quency throttling. - Temperature raised from 90=C2=B0C to 95=C2=B0C, hysteresis reduced from 5= =C2=B0C to 1=C2=B0C. - Adds `#include ` for `THERMAL_NO_LIMIT`. - Critical trip points remain unchanged at 115=C2=B0C. The `cooling-maps` nodes are placed before `trips` in each thermal zone. Th= e DT binding for thermal zones doesn't mandate ordering, so this is fine, t= hough it's slightly unconventional (most existing DTs put `trips` first). N= ot a blocker. No issues. --- Generated by Claude Code Patch Reviewer