From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/registers: Add perfcntr json
Date: Mon, 25 May 2026 18:21:39 +1000
Message-ID: <review-patch5-20260522173349.55491-6-robin.clark@oss.qualcomm.com>
In-Reply-To: <20260522173349.55491-6-robin.clark@oss.qualcomm.com>
References: <20260522173349.55491-1-robin.clark@oss.qualcomm.com> <20260522173349.55491-6-robin.clark@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Adds perfcntr JSON tables and Makefile build rules for generating the C tables. The Makefile `define adreno_perfcntrs` template is clean. The `msm_perfcntr.h` header defines the counter/group data structures well. The `TODO` comment about a2xx/a5xx having different `.xml` args is honest about a known limitation.

One minor observation: in `msm_perfcntr.h`:

```c
struct msm_perfcntr_group {
   ...
   const struct msm_perfcntr_counter *counters;
};
```

The indentation uses spaces (3-space) which is atypical for kernel code (normally tabs). This is consistent within the file though and likely auto-generated.

---
Generated by Claude Code Patch Reviewer