From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: analogix_dp: Enable hclk for RK3588 Date: Tue, 26 May 2026 07:12:12 +1000 Message-ID: In-Reply-To: <20260525125331.140059-6-damon.ding@rock-chips.com> References: <20260525125331.140059-1-damon.ding@rock-chips.com> <20260525125331.140059-6-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good use of `devm_clk_get_optional_enabled()`: ```c + clk = devm_clk_get_optional_enabled(dev, "hclk"); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get hclk property\n"); ``` The `_optional` variant is correct here -- RK3288 and RK3399 don't have this clock, so the driver must tolerate its absence. The `_enabled` variant means the clock stays on via devres lifecycle, which matches the commit message's statement that hclk "must remain enabled during probe." The local `clk` variable is not stored in the struct, which is fine since devres handles cleanup. Appropriate `Fixes:` tag. No issues. --- Generated by Claude Code Patch Reviewer