From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: emit Rust metadata for dependent modules
Date: Thu, 28 May 2026 12:22:00 +1000
Message-ID: <review-patch5-20260527-nova-exports-v2-5-06de4c556d55@nvidia.com>
In-Reply-To: <20260527-nova-exports-v2-5-06de4c556d55@nvidia.com>
References: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> <20260527-nova-exports-v2-5-06de4c556d55@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Generates `.rmeta` (Rust crate metadata) so `nova-drm` can resolve types at compile time.

```makefile
quiet_cmd_rustc_rmeta_rs = RUSTC RMETA $@
      cmd_rustc_rmeta_rs = mkdir -p $(dir $@); \
        $(rust_common_cmd) --emit=metadata=$@ \
        --emit=obj=$(basename $@).o $<; \
        rm -f $(basename $@).o
```

Key design decisions:
- Builds in a private directory (`.nova_core_rmeta/`) to avoid racing with the main `nova_core.o` build during parallel make. This is a sensible precaution.
- The intermediate `.o` file from the metadata build is immediately deleted since only the `.rmeta` is needed.
- A final `if_changed,copy` step places the metadata at a stable path.

**Minor observation:** The `--emit=obj=$(basename $@).o` plus `rm -f` is needed because rustc insists on emitting an object when also emitting metadata. The `rm -f` cleanup is fine.

**No blocking issues.**

---
Generated by Claude Code Patch Reviewer