From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: analogix_dp: Enable hclk for RK3588 Date: Wed, 27 May 2026 13:55:45 +1000 Message-ID: In-Reply-To: <20260527024336.191433-6-damon.ding@rock-chips.com> References: <20260527024336.191433-1-damon.ding@rock-chips.com> <20260527024336.191433-6-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good use of `devm_clk_get_optional_enabled()`: ```c + clk =3D devm_clk_get_optional_enabled(dev, "hclk"); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get hclk property\n"); ``` Using `optional` is the right call for backward compatibility =E2=80=94 exi= sting DTS without `hclk` won't break. The clock is device-managed and stays= enabled for the device lifetime, which matches the commit message's descri= ption that hclk must remain enabled during probe (and operation). The local= `clk` variable is unused after the call, but that's fine since `devm_` han= dles the lifecycle. No issues. --- Generated by Claude Code Patch Reviewer