public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: MAINTAINERS: serdev: Add self for serdev
Date: Thu, 04 Jun 2026 15:18:44 +1000	[thread overview]
Message-ID: <review-patch5-20260530-rust_serdev-v10-5-65d1d5db876c@posteo.de> (raw)
In-Reply-To: <20260530-rust_serdev-v10-5-65d1d5db876c@posteo.de>

Patch Review

```diff
-M:	Rob Herring <robh@kernel.org>
+M:	Markus Probst <markus.probst@posteo.de>
```

This replaces Rob as maintainer entirely rather than adding Markus as co-maintainer. The commit message references Rob's message about needing someone else to maintain serdev. This seems like a significant ownership change that Rob should explicitly Ack.

---

**Summary of key issues:**

1. **Bug (Medium):** `Timeout::Max` maps to 0 which is incorrect for `wait_until_sent` — it would mean "don't wait" instead of "wait forever".
2. **Typo:** "partiy" in `Parity::Even` doc comment.
3. **Broken doc link:** `[ Device::wait_until_sent`]` in `write` method docs.
4. **Design question:** `unwrap_or_default()` silently converting overflow to 0 (infinite timeout) in `Timeout::into_jiffies`.
5. **Minor:** `ssize_t` to `i32` truncation in `write_all` error check path.
6. **Process:** MAINTAINERS change replacing Rob entirely should have his explicit Ack.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  5:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30 19:25 [PATCH v10 0/5] rust: add basic serial device bus abstractions Markus Probst
2026-05-30 19:25 ` [PATCH v10 1/5] rust: devres: return reference in `devres::register` Markus Probst
2026-06-04  5:18   ` Claude review: " Claude Code Review Bot
2026-05-30 19:25 ` [PATCH v10 2/5] serdev: add rust private data to serdev_device Markus Probst
2026-06-04  5:18   ` Claude review: " Claude Code Review Bot
2026-05-30 19:25 ` [PATCH v10 3/5] rust: add basic serial device bus abstractions Markus Probst
2026-06-04  5:18   ` Claude review: " Claude Code Review Bot
2026-05-30 19:25 ` [PATCH v10 4/5] samples: rust: add Rust serial device bus sample device driver Markus Probst
2026-06-04  5:18   ` Claude review: " Claude Code Review Bot
2026-05-30 19:25 ` [PATCH v10 5/5] MAINTAINERS: serdev: Add self for serdev Markus Probst
2026-06-04  5:18   ` Claude Code Review Bot [this message]
2026-06-04  5:18 ` Claude review: rust: add basic serial device bus abstractions Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-03 15:56 [PATCH v12 0/3] " Markus Probst via B4 Relay
2026-06-03 15:56 ` [PATCH v12 3/3] MAINTAINERS: serdev: Add self for serdev Markus Probst via B4 Relay
2026-06-04  1:33   ` Claude review: " Claude Code Review Bot
2026-05-30 22:51 [PATCH v11 0/3] rust: add basic serial device bus abstractions Markus Probst via B4 Relay
2026-05-30 22:51 ` [PATCH v11 3/3] MAINTAINERS: serdev: Add self for serdev Markus Probst via B4 Relay
2026-06-04  5:07   ` Claude review: " Claude Code Review Bot
2026-05-30 17:36 [PATCH v9 0/3] rust: add basic serial device bus abstractions Markus Probst
2026-05-30 17:36 ` [PATCH v9 3/3] MAINTAINERS: serdev: Add self for serdev Markus Probst
2026-06-04  5:28   ` Claude review: " Claude Code Review Bot
2026-05-30  1:13 [PATCH v8 0/5] rust: add basic serial device bus abstractions Markus Probst via B4 Relay
2026-05-30  1:13 ` [PATCH v8 5/5] MAINTAINERS: serdev: Add self for serdev Markus Probst via B4 Relay
2026-06-04  5:57   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260530-rust_serdev-v10-5-65d1d5db876c@posteo.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox