From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Date: Thu, 04 Jun 2026 14:06:56 +1000 Message-ID: In-Reply-To: <20260601-dd-maint-2-v3-5-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> <20260601-dd-maint-2-v3-5-4a15b241bd3c@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the key bug fix in the series. On i386, `struct _ddebug_classmap` is 28 bytes, so the `__dyndbg` section after `__dyndbg_classes` gets misaligned, causing a NULL ptr deref. The fix adds ALIGN to the base macros and introduces `_ALIGNED` variants. The approach of making ALIGN(8) the default and adding `_ALIGNED` variants for explicit overrides is sound. The ORC table `ALIGN(4)` addition matches the code's `__align()` attribute. No issues. --- Generated by Claude Code Patch Reviewer