From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: analogix_dp: Enable hclk for RK3588 Date: Thu, 04 Jun 2026 14:37:02 +1000 Message-ID: In-Reply-To: <20260601065100.1103873-6-damon.ding@rock-chips.com> References: <20260601065100.1103873-1-damon.ding@rock-chips.com> <20260601065100.1103873-6-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Uses `devm_clk_get_optional_enabled()` to acquire and enable the hclk: ```c + clk = devm_clk_get_optional_enabled(dev, "hclk"); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get hclk property\n"); ``` Good design choices: - `optional` ensures backward compatibility with older DTS that lack the third clock - `enabled` keeps the clock on for the lifetime of the device (correct per the commit message: hclk "must remain enabled during probe") - The return value is intentionally not stored in the struct since it's devres-managed and never toggled No issues. --- Generated by Claude Code Patch Reviewer