From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Date: Thu, 04 Jun 2026 12:12:47 +1000 Message-ID: In-Reply-To: <20260602-dd-maint-2-v4-5-19a1445585a8@gmail.com> References: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> <20260602-dd-maint-2-v4-5-19a1445585a8@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **This is the most important patch in the series** -- a real bug fix for a NULL pointer dereference on i386 caused by misaligned `__dyndbg` section following a `__dyndbg_classes` section where `struct _ddebug_classmap` is 28 bytes. The approach is correct: add `ALIGN(8)` inside the BOUNDED_SECTION macros by default, and introduce `_ALIGNED` variants for callers that need a different alignment. The new `BOUNDED_SECTION_BY_ALIGNED` macro passes through the caller's alignment, which is clean. One minor note: the commit message has unfilled `v3:` and `v2:` sections with raw changelog text that should ideally be below the `---` line, but it appears they are (checking... yes, they're between `---` markers, so they won't be in the final commit message). --- Generated by Claude Code Patch Reviewer