From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi_state_helper: Add ctx-aware hotplug helper for SCDC sync Date: Thu, 04 Jun 2026 13:33:47 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-5-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-5-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The original `drm_atomic_helper_connector_hdmi_update()` was void. Converting it to return `int` and threading `ret` through is done correctly. The disconnect path now calls `drm_scdc_sync_status(connector, false, ctx)` which is a no-op (the function early-returns for `plugged=false || !scrambler_enabled`), so this is harmless. --- Generated by Claude Code Patch Reviewer