From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: convert to keyworded projection syntax Date: Thu, 04 Jun 2026 12:43:27 +1000 Message-ID: In-Reply-To: <20260602-projection-syntax-rework-v2-5-6989470f5440@garyguo.net> References: <20260602-projection-syntax-rework-v2-0-6989470f5440@garyguo.net> <20260602-projection-syntax-rework-v2-5-6989470f5440@garyguo.net> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward conversion of three call sites in `drivers/gpu/nova-core/gsp/cmdq.rs` from `[i]` to `[build: i]`: ```rust - dma_write!(gsp_mem, .ptes.0[i], PteArray::<0>::entry(start, i)?); + dma_write!(gsp_mem, .ptes.0[build: i], PteArray::<0>::entry(start, i)?); ``` ```rust - let data = ptr::project!(mut self.0.as_mut_ptr(), .cpuq.msgq.data[0]); + let data = ptr::project!(mut self.0.as_mut_ptr(), .cpuq.msgq.data[build: 0]); ``` All three conversions correctly use `build:` since the original code was using the build-time checked form. Already has Reviewed-by from Alexandre and Alice. No issues. --- Generated by Claude Code Patch Reviewer