From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: iommu/arm-smmu: Add qcom,shikra-mdss to Qualcomm SMMU client tables Date: Thu, 04 Jun 2026 11:45:51 +1000 Message-ID: In-Reply-To: <20260603-shikra-display-v1-5-aeac1b94faa7@oss.qualcomm.com> References: <20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com> <20260603-shikra-display-v1-5-aeac1b94faa7@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Sorting violation in `qcom_smmu_actlr_client_of_match[]`**: The existing = table is strictly alphabetically sorted (`qcm2290` =E2=86=92 `sa8775p` =E2= =86=92 `sc7280` =E2=86=92 `sc8180x` =E2=86=92 `sc8280xp` =E2=86=92 `sm6115`= =E2=86=92 ...). The patch inserts `shikra-mdss` between `qcm2290-mdss` and= `sa8775p-mdss`: ```c { .compatible =3D "qcom,qcm2290-mdss", .data =3D (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) }, + { .compatible =3D "qcom,shikra-mdss", + .data =3D (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) }, { .compatible =3D "qcom,sa8775p-mdss", ``` Alphabetically `"sh" > "sc"`, so `shikra-mdss` should go between `sc8280xp-= mdss` and `sm6115-mdss`. **Same issue in `qcom_smmu_client_of_match[]`**: The existing table is alph= abetically sorted (`qcm2290-mdss` =E2=86=92 `sar2130p-mdss` =E2=86=92 `sc71= 80-mdss` =E2=86=92 ... =E2=86=92 `sdm845-mdss` =E2=86=92 `sm6115-mdss` =E2= =86=92 ...). The patch inserts `shikra-mdss` between `qcm2290-mdss` and `sa= r2130p-mdss`: ```c { .compatible =3D "qcom,qcm2290-mdss" }, + { .compatible =3D "qcom,shikra-mdss" }, { .compatible =3D "qcom,sar2130p-mdss" }, ``` The correct position would be between `sdm845-mdss` and `sm6115-mdss`. **Functionally correct**: The SMMU prefetch settings (`PREFETCH_SHALLOW | C= PRE | CMTLB`) matching QCM2290 makes sense given identical display hardware= . The client table entry is needed since there's no fallback compatible at = the SMMU client match level. --- Generated by Claude Code Patch Reviewer