From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Extract v3d_job_add_syncobjs() helper Date: Thu, 04 Jun 2026 11:24:40 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-5-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-5-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean extraction of syncobj dependency setup from `v3d_job_init()` into a separate helper. Adds `job->queue` field to `struct v3d_job` to enable the helper to check `se->wait_stage == job->queue`. No functional change, prepares for later patches. The `// TODO: Investigate why this was filtered out for the IOCTL.` comments are carried forward from existing code (they're removed in patch 6). Reviewed-by: Tvrtko Ursulin. No issues. --- Generated by Claude Code Patch Reviewer