From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: update for u64 i_ino
Date: Fri, 27 Feb 2026 11:50:54 +1000 [thread overview]
Message-ID: <review-patch52-20260226-iino-u64-v1-52-ccceff366db9@kernel.org> (raw)
In-Reply-To: <20260226-iino-u64-v1-52-ccceff366db9@kernel.org>
Patch Review
**Status: Correct, no issues.**
This patch updates two `seq_printf` format specifiers in `amdgpu_bo_print_info()` from `%lu` to `%llu` to match the new `u64` type of `i_ino`.
The change:
```c
- seq_printf(m, " imported from ino:%lu", file_inode(dma_buf->file)->i_ino);
+ seq_printf(m, " imported from ino:%llu", file_inode(dma_buf->file)->i_ino);
else if (dma_buf)
- seq_printf(m, " exported as ino:%lu", file_inode(dma_buf->file)->i_ino);
+ seq_printf(m, " exported as ino:%llu", file_inode(dma_buf->file)->i_ino);
```
Both changes are correct. The `%llu` format specifier matches `u64` (which is `unsigned long long` on all architectures). The expressions `file_inode(dma_buf->file)->i_ino` are the only uses of `i_ino` in this file, so coverage is complete.
No functional, semantic, or style concerns.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 15:55 [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 Jeff Layton
2026-02-26 15:55 ` [PATCH 52/61] drm/amdgpu: update for u64 i_ino Jeff Layton
2026-02-27 1:50 ` Claude Code Review Bot [this message]
2026-02-26 15:55 ` [PATCH 56/61] dma-buf: update format string " Jeff Layton
2026-02-27 1:50 ` Claude review: " Claude Code Review Bot
2026-02-27 1:50 ` Claude review: vfs: change inode->i_ino from unsigned long to u64 Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch52-20260226-iino-u64-v1-52-ccceff366db9@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox