From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: interconnect: Prefer IS_ERR_OR_NULL over manual NULL check Date: Thu, 12 Mar 2026 07:27:20 +1000 Message-ID: In-Reply-To: <20260310-b4-is_err_or_null-v1-55-bd63b656022d@avm.de> References: <20260310-b4-is_err_or_null-v1-55-bd63b656022d@avm.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Semantic concern:** ```c - if (!path || WARN_ON(IS_ERR(path))) + if (WARN_ON(IS_ERR_OR_NULL(path))) ``` `icc_put(NULL)` is likely a valid no-op (similar to `kfree(NULL)`) used by callers that conditionally acquire an ICC path. Making it trigger `WARN_ON` would produce false-positive warnings. This patch should be **dropped**. --- Generated by Claude Code Patch Reviewer