From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: update format string for u64 i_ino
Date: Fri, 27 Feb 2026 11:50:54 +1000 [thread overview]
Message-ID: <review-patch56-20260226-iino-u64-v1-56-ccceff366db9@kernel.org> (raw)
In-Reply-To: <20260226-iino-u64-v1-56-ccceff366db9@kernel.org>
Patch Review
**Status: Correct, no issues.**
This patch updates one `seq_printf` format specifier in `dma_buf_debug_show()` from `%08lu` to `%08llu`.
The change:
```c
- seq_printf(s, "%08zu\t%08x\t%08x\t%08ld\t%s\t%08lu\t%s\n",
+ seq_printf(s, "%08zu\t%08x\t%08x\t%08ld\t%s\t%08llu\t%s\n",
```
This correctly updates the format specifier for the `file_inode(buf_obj->file)->i_ino` argument (the 6th argument after the format string, at line 1716 of the current source). The `%08` width/padding prefix is preserved, which is correct — the field width specifier is orthogonal to the length modifier.
No functional, semantic, or style concerns. The only `i_ino` usage in this file is covered by this change.
---
**Summary:** Both patches are trivially correct mechanical changes. For the DRM/dma-buf subsystem:
Acked-by for both patches.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 15:55 [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 Jeff Layton
2026-02-26 15:55 ` [PATCH 52/61] drm/amdgpu: update for u64 i_ino Jeff Layton
2026-02-27 1:50 ` Claude review: " Claude Code Review Bot
2026-02-26 15:55 ` [PATCH 56/61] dma-buf: update format string " Jeff Layton
2026-02-27 1:50 ` Claude Code Review Bot [this message]
2026-02-27 1:50 ` Claude review: vfs: change inode->i_ino from unsigned long to u64 Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch56-20260226-iino-u64-v1-56-ccceff366db9@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox