From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH 56/61] clk: Prefer IS_ERR_OR_NULL over manual NULL check
Date: Thu, 12 Mar 2026 07:27:20 +1000
Message-ID: <review-patch56-abAa9vQg4BSxl1BJ@redhat.com>
In-Reply-To: <abAa9vQg4BSxl1BJ@redhat.com>
References: <abBlpGKO842B3yl9@google.com> <abAa9vQg4BSxl1BJ@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Semantic concern (same as patch 55):**
```c
-	if (!clk || WARN_ON_ONCE(IS_ERR(clk)))
+	if (WARN_ON_ONCE(IS_ERR_OR_NULL(clk)))
```
Both `clk_unregister()` and `__clk_put()` likely intend to silently accept =
NULL (the clk API explicitly supports optional clocks). Triggering `WARN_ON=
_ONCE` for NULL would break this contract. The `timer-pxa.c` change in the =
same patch is fine. This should be **split** =E2=80=94 keep the timer-pxa h=
unk, drop the clk.c hunks.

---
Generated by Claude Code Patch Reviewer