From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH 57/61] reset: Prefer IS_ERR_OR_NULL over manual NULL check Date: Thu, 12 Mar 2026 07:27:20 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Semantic concern (same pattern):** ```c - if (!rstc || WARN_ON(IS_ERR(rstc))) + if (WARN_ON(IS_ERR_OR_NULL(rstc))) ``` The reset control API intentionally supports optional resets; `reset_control_release(NULL)` should be a silent no-op. The commit message even has a typo: "Semantich change". This patch should be **dropped**. --- Generated by Claude Code Patch Reviewer