From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arch/x86: Prefer IS_ERR_OR_NULL over manual NULL check Date: Thu, 12 Mar 2026 07:27:20 +1000 Message-ID: In-Reply-To: <20260310-b4-is_err_or_null-v1-58-bd63b656022d@avm.de> References: <20260310-b4-is_err_or_null-v1-58-bd63b656022d@avm.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Two changes. The `callthunks.c` WARN_ON_ONCE change has the same semantic c= oncern as patches 55-57. The `irq.c` change just removes a redundant `likel= y()` around `!IS_ERR_OR_NULL()` =E2=80=94 that part is fine and should be s= plit out. ```c - if (!dest || WARN_ON_ONCE(IS_ERR(dest))) + if (WARN_ON_ONCE(IS_ERR_OR_NULL(dest))) ``` Here it's more defensible since `dest` being NULL from `callthunks_get_modu= le_thunk()` is likely a real error, but this needs architecture maintainer = judgment. --- Generated by Claude Code Patch Reviewer