From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: implement IVPU_DBG_* as a dyndbg classmap Date: Sat, 14 Mar 2026 07:00:29 +1000 Message-ID: In-Reply-To: <20260313132103.2529746-60-jim.cromie@gmail.com> References: <20260313132103.2529746-1-jim.cromie@gmail.com> <20260313132103.2529746-60-jim.cromie@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Bug: `IVPU_DBG_IOCTL` is missing from the `DRM_CLASSMAP_DEFINE` classnames list.** The enum defines 15 categories (REG through IOCTL at lines 13842-13860) but the classmap only lists 14 names (ending at `"IVPU_DBG_MMU_MAP"` at line 13809). `ivpu_dbg(vdev, IOCTL, ...)` calls will reference class_id 30, which has no name in the classmap and won't be controllable. **Bug: The dyndbg version of `ivpu_dbg()` loses the `[type]` prefix.** The non-dyndbg version formats as: ```c dev_dbg((vdev)->drm.dev, "[%s] " fmt, #type, ##args); ``` But the dyndbg version just passes `fmt` directly: ```c _dynamic_func_call_cls(IVPU_DBG_##type, fmt, __dynamic_dev_dbg, (vdev)->drm.dev, fmt, ##__VA_ARGS__) ``` This changes visible log output for ivpu when dyndbg is active. --- Generated by Claude Code Patch Reviewer