From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Date: Wed, 11 Feb 2026 16:37:16 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-7-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-7-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Replaces explicit `skip_connector` boolean with check for `next_bridge` presence. ```c - if (!dp->plat_data->skip_connector) { + if (!dp->plat_data->next_bridge) { ``` **Review:** - Reduces redundant state (if there's a next_bridge, we skip connector creation) - More idiomatic - checks actual presence rather than a separate flag - Removes potential for flag/state mismatch bugs **Verdict:** Excellent simplification. --- --- Generated by Claude Code Patch Reviewer