From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo Date: Tue, 17 Feb 2026 15:48:07 +1000 Message-ID: In-Reply-To: <20260217-nova-misc-v3-6-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> <20260217-nova-misc-v3-6-b4e2d45eafbc@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces a manual `unsafe impl Zeroable` with `#[derive(Zeroable)]`. The safety justification ("This struct only contains integer types and fixed-size arrays for which all bit patterns are valid") is removed along with the manual impl. > +#[derive(Zeroable)] > pub(crate) struct GspStaticConfigInfo(bindings::GspStaticConfigInfo_t); Since `GspStaticConfigInfo` is `#[repr(transparent)]` over a bindgen type, the derive macro needs the inner type to also be `Zeroable`. The commit message says the derive macro now works on tuple structs, so presumably the infrastructure handles this. If `bindings::GspStaticConfigInfo_t` doesn't implement `Zeroable`, the derive would fail at compile time, so this is safe. No issues found. --- Generated by Claude Code Patch Reviewer