From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: add support for pixel 3a xl with the tianma panel
Date: Tue, 17 Feb 2026 15:51:44 +1000 [thread overview]
Message-ID: <review-patch6-20260217000854.131242-7-mailingradian@gmail.com> (raw)
In-Reply-To: <20260217000854.131242-7-mailingradian@gmail.com>
Patch Review
> +/*
> + * Device tree for Google Pixel 3a XL with the panel connected to the Samsung
> + * Display Controller.
This comment says "Samsung Display Controller" but the file is `sdm670-google-bonito-tianma.dts` and uses the `novatek,nt37700f` compatible. The cover letter mentions this was addressed in v2 ("mention the sdc panel"), but the comment still describes the wrong panel variant. This should say something like "with the Tianma panel" rather than "Samsung Display Controller."
> + compatible = "google,bonito-tianma", "google,bonito", "qcom,sdm670";
Matches the binding added in patch 1. Correct.
> +&battery {
> + charge-full-design-microamp-hours = <3700000>;
> +};
3700 mAh for the XL variant vs 3000 mAh for the standard 3a. Reasonable.
> +&panel {
> + compatible = "novatek,nt37700f";
> + status = "okay";
> +};
Uses the panel driver from patch 3. The `status = "okay"` overrides the `"disabled"` from the common include. Correct.
> +&rmi4_f12 {
> + touchscreen-x-mm = <69>;
> + touchscreen-y-mm = <137>;
> +};
Touchscreen dimensions match the panel physical size (69mm x 137mm) specified in the panel driver's `drm_display_mode`. Consistent.
The Makefile addition places the new dtb entry after `sdm670-google-sargo.dtb` but alphabetically `bonito` comes before `sargo`. Not a functional issue, but the Makefile entry could be placed in alphabetical order for consistency.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-17 5:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 0:08 [PATCH v2 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-17 0:08 ` [PATCH v2 1/6] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 3/6] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 4/6] arm64: dts: qcom: sdm670-google-sargo: add touchscreen and display labels Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-17 5:51 ` Claude Code Review Bot [this message]
2026-02-17 5:51 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 0:26 [PATCH v3 0/5] " Richard Acayan
2026-03-10 0:26 ` [PATCH v3 5/5] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-02-10 2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10 2:33 ` [PATCH 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-11 6:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260217000854.131242-7-mailingradian@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox