From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Date: Tue, 17 Feb 2026 15:51:44 +1000 Message-ID: In-Reply-To: <20260217000854.131242-7-mailingradian@gmail.com> References: <20260217000854.131242-1-mailingradian@gmail.com> <20260217000854.131242-7-mailingradian@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > +/* > + * Device tree for Google Pixel 3a XL with the panel connected to the Samsung > + * Display Controller. This comment says "Samsung Display Controller" but the file is `sdm670-google-bonito-tianma.dts` and uses the `novatek,nt37700f` compatible. The cover letter mentions this was addressed in v2 ("mention the sdc panel"), but the comment still describes the wrong panel variant. This should say something like "with the Tianma panel" rather than "Samsung Display Controller." > + compatible = "google,bonito-tianma", "google,bonito", "qcom,sdm670"; Matches the binding added in patch 1. Correct. > +&battery { > + charge-full-design-microamp-hours = <3700000>; > +}; 3700 mAh for the XL variant vs 3000 mAh for the standard 3a. Reasonable. > +&panel { > + compatible = "novatek,nt37700f"; > + status = "okay"; > +}; Uses the panel driver from patch 3. The `status = "okay"` overrides the `"disabled"` from the common include. Correct. > +&rmi4_f12 { > + touchscreen-x-mm = <69>; > + touchscreen-y-mm = <137>; > +}; Touchscreen dimensions match the panel physical size (69mm x 137mm) specified in the panel driver's `drm_display_mode`. Consistent. The Makefile addition places the new dtb entry after `sdm670-google-sargo.dtb` but alphabetically `bonito` comes before `sargo`. Not a functional issue, but the Makefile entry could be placed in alphabetical order for consistency. --- Generated by Claude Code Patch Reviewer