public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm: Use common ancestor of evictor and evictee as limit pool
Date: Fri, 27 Feb 2026 13:36:29 +1000	[thread overview]
Message-ID: <review-patch6-20260225-dmemcg-aggressive-protect-v4-6-de847ab35184@gmx.de> (raw)
In-Reply-To: <20260225-dmemcg-aggressive-protect-v4-6-de847ab35184@gmx.de>

Patch Review

This correctly implements recursive protection semantics for sibling cgroup competition. The commit message explanation is excellent.

The self-eviction guard is important and well-commented:

```c
+	if (evict_walk->alloc_state->only_evict_unprotected &&
+			bo->resource->css == evict_walk->alloc_state->charge_pool)
+		return 0;
```

Without this, `dmem_cgroup_state_evict_valuable` would allow a cgroup to evict from itself (since a cgroup is always allowed to self-evict), which would defeat the purpose of `only_evict_unprotected`.

The common ancestor fallback logic is correct:

```c
+	if (!limit_pool)
+		limit_pool = dmem_cgroup_common_ancestor(bo->resource->css,
+							 evict_walk->alloc_state->charge_pool);
```

The extensive comment explaining why the common ancestor matters for `effective_protection` calculation is very helpful.

**One observation**: The `below_min`/`below_low` checks in Patch 5 use `NULL` (global root) while eviction decisions in this patch use the common ancestor. These are at different logical levels - the global check determines the "policy" (should we attempt aggressive eviction?) while the per-candidate check determines the "mechanism" (is this specific buffer evictable?). This design makes sense.

No blocking issues with this patch.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-27  3:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 12:10 [PATCH v4 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-02-25 12:10 ` [PATCH v4 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-02-27  3:36   ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 2/6] cgroup/dmem: Add dmem_cgroup_common_ancestor helper Natalie Vock
2026-02-25 17:16   ` Tejun Heo
2026-02-27  3:36   ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-02-25 15:18   ` Tvrtko Ursulin
2026-02-25 15:27   ` Tvrtko Ursulin
2026-02-26  8:56     ` Tvrtko Ursulin
2026-02-27  3:36   ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-02-25 15:33   ` Tvrtko Ursulin
2026-02-25 16:01     ` Tvrtko Ursulin
2026-02-27  3:36   ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-02-27  3:36   ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 ` [PATCH v4 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-02-27  3:36   ` Claude Code Review Bot [this message]
2026-02-27  3:36 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-02 12:37 [PATCH v5 0/6] " Natalie Vock
2026-03-02 12:37 ` [PATCH v5 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-03-13 11:39 [PATCH v6 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-03-13 11:40 ` [PATCH v6 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260225-dmemcg-aggressive-protect-v4-6-de847ab35184@gmx.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox