From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: unconditionally call variable payload handling Date: Fri, 27 Feb 2026 12:21:59 +1000 Message-ID: In-Reply-To: <20260226-cmdq-continuation-v3-6-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> <20260226-cmdq-continuation-v3-6-572ab9916766@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Removes the `if command_size > size_of::()` guard around variab= le payload initialization and calls it unconditionally. The explicit `drop(= sbuffer)` is added to release mutable borrows before the checksum computati= on. This change is motivated by patch 8: the `SplitCommand` wrapper needs the `= SBufferIter` to be created unconditionally. It also adds a defensive check = =E2=80=94 `sbuffer.is_empty()` will catch cases where a command claims `var= iable_payload_len() =3D=3D 0` but the `init_variable_payload` impl disagree= s. The `drop(sbuffer)` is worth noting =E2=80=94 it's needed because `sbuffer`= holds mutable borrows on `payload_1` and `dst.contents.1`, which would oth= erwise prevent access to `dst.header` for checksum computation. Good practi= ce to make this explicit. --- Generated by Claude Code Patch Reviewer