From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: unconditionally call variable payload handling Date: Tue, 03 Mar 2026 13:34:48 +1000 Message-ID: In-Reply-To: <20260302-cmdq-continuation-v4-6-c011f15aad58@nvidia.com> References: <20260302-cmdq-continuation-v4-0-c011f15aad58@nvidia.com> <20260302-cmdq-continuation-v4-6-c011f15aad58@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the `if command_size > size_of::()` guard around `init_variable_payload`, making it always run even for commands with no variable payload. The explicit `drop(sbuffer)` is added to release the mutable borrows before the checksum computation. This is a sensible defensive change. For zero-payload commands, `init_variable_payload` is a no-op (default implementation returns `Ok(())`), and `sbuffer.is_empty()` will be true since the iterator has zero bytes remaining. The `drop(sbuffer)` is necessary for borrow checker correctness. --- Generated by Claude Code Patch Reviewer