From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm: Use common ancestor of evictor and evictee as limit pool
Date: Tue, 03 Mar 2026 13:29:39 +1000 [thread overview]
Message-ID: <review-patch6-20260302-dmemcg-aggressive-protect-v5-6-ffd3a2602309@gmx.de> (raw)
In-Reply-To: <20260302-dmemcg-aggressive-protect-v5-6-ffd3a2602309@gmx.de>
Patch Review
**Purpose:** Uses the common ancestor of evictor and evictee as the root for protection calculation, enabling correct behavior for sibling cgroup prioritization.
**Self-eviction guard:**
```c
if (evict_walk->alloc_state->only_evict_unprotected &&
bo->resource->css == evict_walk->alloc_state->charge_pool)
return 0;
```
This prevents a protected cgroup from evicting its own buffers during the "only unprotected" pass. The pointer comparison checks for exact same pool — not parent/child relationships. This is intentional: a cgroup should be allowed to evict from its own children, but not from itself when it's trying to enforce protection.
**Common ancestor logic:** Well-motivated by the comment:
```c
/*
* ...Recursive protection distributes cgroup protection afforded
* to a parent cgroup but not used explicitly by a child cgroup between
* all child cgroups...
*/
```
Without this, two sibling cgroups where one is protected and the other isn't would both appear equally protected (due to recursive distribution from their common parent), preventing the protected one from stealing from the unprotected one.
**Reference management:**
```c
ancestor = dmem_cgroup_common_ancestor(bo->resource->css,
evict_walk->alloc_state->charge_pool);
limit_pool = ancestor;
...
evict_valuable = dmem_cgroup_state_evict_valuable(limit_pool, ...);
if (ancestor)
dmem_cgroup_pool_state_put(ancestor);
```
The `put` after use is correct, but relies on `dmem_cgroup_common_ancestor()` returning a referenced pool (see concern in patch 2 review).
**Formatting nit:** The self-eviction check uses non-standard indentation:
```c
if (evict_walk->alloc_state->only_evict_unprotected &&
bo->resource->css == evict_walk->alloc_state->charge_pool)
```
Kernel style typically aligns continuation lines to the opening parenthesis, or uses a single tab indent. The double-tab here is inconsistent with the rest of the series.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 3:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 12:37 [PATCH v5 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-03-02 12:37 ` [PATCH v5 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-02 14:38 ` Maarten Lankhorst
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-03-02 15:08 ` Tvrtko Ursulin
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-03-02 15:25 ` Tvrtko Ursulin
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-03-02 17:02 ` Tvrtko Ursulin
2026-03-03 3:29 ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-03 3:29 ` Claude Code Review Bot [this message]
2026-03-03 3:29 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-13 11:39 [PATCH v6 0/6] " Natalie Vock
2026-03-13 11:40 ` [PATCH v6 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-13 21:10 ` Claude review: " Claude Code Review Bot
2026-02-25 12:10 [PATCH v4 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-02-25 12:10 ` [PATCH v4 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-02-27 3:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260302-dmemcg-aggressive-protect-v5-6-ffd3a2602309@gmx.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox