From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: trace: reorder TP_STRUCT__entry fields for better packing on 32-bit Date: Wed, 04 Mar 2026 08:15:03 +1000 Message-ID: In-Reply-To: <20260302-iino-u64-v2-6-e5388800dae0@kernel.org> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-6-e5388800dae0@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Excellent follow-up patch. After widening ino fields to `u64`, this reorders struct entries to put 64-bit fields first, eliminating alignment holes on 32-bit platforms (especially ARM with 8-byte u64 alignment). The strategy is consistent: u64/loff_t/time64_t first, then pointers/unsigned long, then smaller types. Since `TP_fast_assign` and `TP_printk` reference fields by name, reordering is safe. This patch should come immediately after patch 005 (which it does), since it addresses the padding introduced by the type widening. **Well done, no issues.** --- Generated by Claude Code Patch Reviewer