From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: use Coherent::init to initialize GspFwWprMeta
Date: Wed, 04 Mar 2026 07:03:03 +1000
Message-ID: <review-patch6-20260303162314.94363-7-dakr@kernel.org>
In-Reply-To: <20260303162314.94363-7-dakr@kernel.org>
References: <20260303162314.94363-1-dakr@kernel.org> <20260303162314.94363-7-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The conversion from tuple struct `GspFwWprMeta(bindings::GspFwWprMeta)` to named-field struct `GspFwWprMeta { inner: ... }` is necessary to use the `init!` macro with `<-` syntax for in-place initialization.

The change from `..Default::default()` to `..Zeroable::init_zeroed()` is the correct pin-init equivalent for zeroing remaining fields.

The return type change from `Self` to `impl Init<Self>` is clean and avoids the intermediate stack allocation of `GspFwWprMeta`.

No issues.

---
Generated by Claude Code Patch Reviewer