From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: unconditionally call variable payload handling Date: Thu, 05 Mar 2026 13:55:44 +1000 Message-ID: In-Reply-To: <20260304-cmdq-continuation-v5-6-3f19d759ed93@nvidia.com> References: <20260304-cmdq-continuation-v5-0-3f19d759ed93@nvidia.com> <20260304-cmdq-continuation-v5-6-3f19d759ed93@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the `if command_size > size_of::()` guard around the variable payload handling. This is a good defensive change - calling `init_variable_payload` on zero-length payloads is a no-op by default, and the `sbuffer.is_empty()` check will catch any mismatch between `variable_payload_len()` and actual bytes written. The explicit `drop(sbuffer)` is needed because `sbuffer` borrows `payload_1` and `dst.contents.1` mutably, and the subsequent checksum computation needs to read them. Good. --- Generated by Claude Code Patch Reviewer