From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: unconditionally call variable payload handling Date: Mon, 09 Mar 2026 09:11:26 +1000 Message-ID: In-Reply-To: <20260306-cmdq-continuation-v6-6-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> <20260306-cmdq-continuation-v6-6-cc7b629200ee@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves the `SBufferIter::new_writer` and `sbuffer.is_empty()` check outside the `if command_size > size_of::()` conditional. This means the variable payload path runs even when `variable_payload_len() == 0`, making the code defensively catch bugs where a command incorrectly reports its payload size. The addition of `drop(sbuffer)` explicitly ends the mutable borrow before computing the checksum, which is necessary since the `if` block previously scoped the borrow. No issues. --- Generated by Claude Code Patch Reviewer