From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/neutron: Add mailbox support Date: Mon, 09 Mar 2026 08:49:22 +1000 Message-ID: In-Reply-To: <20260306-neutron-v2-6-3019bd8c91ef@nxp.com> References: <20260306-neutron-v2-0-3019bd8c91ef@nxp.com> <20260306-neutron-v2-6-3019bd8c91ef@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **`neutron_mbox_reset_state` return value ignored in `neutron_boot`:** ```c /* Prepare device to receive jobs */ neutron_mbox_reset_state(ndev); ``` The function returns an error if the poll times out, but the caller ignores it. If the firmware doesn't reset, subsequent job submissions will fail silently. Otherwise the mailbox implementation is straightforward and reasonable. --- Generated by Claude Code Patch Reviewer