From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Remove dedicated fence_lock Date: Mon, 09 Mar 2026 08:56:09 +1000 Message-ID: In-Reply-To: <20260306-v3d-reset-locking-improv-v3-6-49864fe00692@igalia.com> References: <20260306-v3d-reset-locking-improv-v3-0-49864fe00692@igalia.com> <20260306-v3d-reset-locking-improv-v3-6-49864fe00692@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward cleanup. Since `v3d_job_update_stats()` no longer takes `queue_lock`, there's no longer a conflict between DMA fence signaling (which needs a spinlock in IRQ context) and stats updates. The `fence_lock` can be folded back into `queue_lock`. This is safe because `queue_lock` is still taken with `spin_lock_irqsave` in all its remaining call sites (bin job run, overflow mem work, IRQ handler), so it's compatible with the IRQ context requirements of `dma_fence_init`. No issues. --- Generated by Claude Code Patch Reviewer