public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: remoteproc: qcom_q6v5_mss: Switch to generic PAS TZ APIs
Date: Mon, 09 Mar 2026 08:59:08 +1000	[thread overview]
Message-ID: <review-patch6-20260306105027.290375-7-sumit.garg@kernel.org> (raw)
In-Reply-To: <20260306105027.290375-7-sumit.garg@kernel.org>

Patch Review

Clean mechanical conversion. The `#include` for `qcom_pas.h` is added after the local includes (after `qcom_q6v5.h`), which is inconsistent with the usual convention of putting system headers before local ones. Minor style nit.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 22:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 10:50 [PATCH 00/14] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-03-06 10:50 ` [PATCH 01/14] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 02/14] firmware: qcom: Add a generic PAS service Sumit Garg
2026-03-06 11:15   ` Krzysztof Kozlowski
2026-03-06 15:40   ` Jeff Johnson
2026-03-06 15:49   ` Jeff Johnson
2026-03-06 19:47   ` Trilok Soni
2026-03-06 20:00     ` Trilok Soni
2026-03-06 22:00     ` Jeff Johnson
2026-03-06 22:16       ` Trilok Soni
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 03/14] firmware: qcom_scm: Migrate to " Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 04/14] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 05/14] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 06/14] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-03-08 22:59   ` Claude Code Review Bot [this message]
2026-03-06 10:50 ` [PATCH 07/14] soc: qcom: mdtloader: " Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 08/14] remoteproc: qcom_wcnss: " Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 09/14] remoteproc: qcom: Select QCOM_PAS_TEE service backend Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 10/14] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 11/14] media: qcom: " Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 12/14] net: ipa: " Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 13/14] wifi: ath12k: " Sumit Garg
2026-03-06 15:52   ` Jeff Johnson
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-06 10:50 ` [PATCH 14/14] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-03-08 22:59   ` Claude review: " Claude Code Review Bot
2026-03-08 22:59 ` Claude review: firmware: qcom: Add OP-TEE PAS service support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-12  6:27 [PATCH v2 00/15] " Sumit Garg
2026-03-12  6:27 ` [PATCH v2 06/15] remoteproc: qcom_q6v5_mss: Switch to generic PAS TZ APIs Sumit Garg
2026-03-13  4:26   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260306105027.290375-7-sumit.garg@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox