From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor
Date: Mon, 09 Mar 2026 07:46:27 +1000 [thread overview]
Message-ID: <review-patch6-20260308-rimob-new-features-v1-6-aa2c330572c0@protonmail.com> (raw)
In-Reply-To: <20260308-rimob-new-features-v1-6-aa2c330572c0@protonmail.com>
Patch Review
Standard `gpio-keys` hall sensor configuration. Uses `EV_SW`/`SW_LID`, `linux,can-disable`, and `wakeup-source` which is the correct pattern for hall sensors on Qualcomm phones.
The `bias-disable` on the pinctrl is appropriate if the hall sensor has an external pull-up. No issues.
---
**Summary of requested changes:**
1. **(Patch 1)** Add a panel-specific compatible string with `novatek,nt35532` as fallback in the binding
2. **(Patch 2)** Use `mipi_dsi_dcs_exit_sleep_mode_multi()` and `mipi_dsi_dcs_set_display_on_multi()` instead of generic writes for DCS commands 0x11 and 0x29
3. **(Patch 2, minor)** Verify whether `select DRM_KMS_HELPER` is actually needed or is already pulled in transitively
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 21:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 15:52 [PATCH 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-08 15:52 ` [PATCH 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-08 16:13 ` Krzysztof Kozlowski
2026-03-08 21:46 ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-08 19:27 ` Dmitry Baryshkov
2026-03-08 21:46 ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-08 15:01 ` Dmitry Baryshkov
2026-03-08 21:46 ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 4/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable WiFi/Bluetooth Cristian Cozzolino via B4 Relay
2026-03-08 15:08 ` Dmitry Baryshkov
2026-03-08 21:46 ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Cristian Cozzolino via B4 Relay
2026-03-08 21:46 ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-08 15:14 ` Dmitry Baryshkov
2026-03-08 21:46 ` Claude Code Review Bot [this message]
2026-03-08 21:46 ` Claude review: Enable new features for flipkart-rimob Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-18 22:28 [PATCH v2 0/6] " Cristian Cozzolino via B4 Relay
2026-03-18 22:28 ` [PATCH v2 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-21 19:00 ` Claude review: " Claude Code Review Bot
2026-03-21 16:23 [PATCH v3 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-21 16:23 ` [PATCH v3 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-21 17:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260308-rimob-new-features-v1-6-aa2c330572c0@protonmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox