From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Date: Mon, 09 Mar 2026 07:46:27 +1000 Message-ID: In-Reply-To: <20260308-rimob-new-features-v1-6-aa2c330572c0@protonmail.com> References: <20260308-rimob-new-features-v1-0-aa2c330572c0@protonmail.com> <20260308-rimob-new-features-v1-6-aa2c330572c0@protonmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Standard `gpio-keys` hall sensor configuration. Uses `EV_SW`/`SW_LID`, `linux,can-disable`, and `wakeup-source` which is the correct pattern for hall sensors on Qualcomm phones. The `bias-disable` on the pinctrl is appropriate if the hall sensor has an external pull-up. No issues. --- **Summary of requested changes:** 1. **(Patch 1)** Add a panel-specific compatible string with `novatek,nt35532` as fallback in the binding 2. **(Patch 2)** Use `mipi_dsi_dcs_exit_sleep_mode_multi()` and `mipi_dsi_dcs_set_display_on_multi()` instead of generic writes for DCS commands 0x11 and 0x29 3. **(Patch 2, minor)** Verify whether `select DRM_KMS_HELPER` is actually needed or is already pulled in transitively --- Generated by Claude Code Patch Reviewer