From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: bus: mhi: Load DDR training data using per-device serial number
Date: Wed, 11 Mar 2026 13:35:23 +1000 [thread overview]
Message-ID: <review-patch6-20260310-sahara_protocol_new_v2-v3-6-994ea4b0d5ad@oss.qualcomm.com> (raw)
In-Reply-To: <20260310-sahara_protocol_new_v2-v3-6-994ea4b0d5ad@oss.qualcomm.com>
Patch Review
Adds per-serial-number DDR training image lookup.
**Issues:**
- **Missing `active_image_id` assignment in the DDR serial-number success path.** When the serial-number firmware load succeeds (line 532-533 in the final file), the code falls through but `context->active_image_id = image_id;` is set at line 559 (after the else block). Looking carefully, the DDR serial success path does NOT return early, so it will reach line 559. However, the else branch at line 544 returns on failure but reaches line 559 on success. This is correct but the flow is confusing and would benefit from restructuring.
- The pre-existing comment `"Suppress error messages that could suggest an a problem"` has a typo: "an a problem" should be "a problem".
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 7:21 [PATCH v3 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-10 7:21 ` [PATCH v3 1/9] Add documentation for Sahara protocol Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:21 ` [PATCH v3 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:22 ` [PATCH v3 3/9] bus: mhi: Match devices exposing the protocol on the SAHARA channel Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:22 ` [PATCH v3 4/9] bus: mhi: Centralize firmware image table selection at probe time Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:22 ` [PATCH v3 5/9] bus: mhi: Add QDU100 variant and image_id firmware fallback Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:22 ` [PATCH v3 6/9] bus: mhi: Load DDR training data using per-device serial number Kishore Batta
2026-03-11 3:35 ` Claude Code Review Bot [this message]
2026-03-10 7:22 ` [PATCH v3 7/9] bus: mhi: Capture DDR training data using command mode Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:22 ` [PATCH v3 8/9] bus: mhi: Expose DDR training data via controller sysfs Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-10 7:22 ` [PATCH v3 9/9] Documentation: ABI: Add sysfs ABI documentation for DDR training data Kishore Batta
2026-03-11 3:35 ` Claude review: " Claude Code Review Bot
2026-03-11 3:35 ` Claude review: Qualcomm Sahara protocol enhancements Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-19 6:31 [PATCH v4 0/9] " Kishore Batta
2026-03-19 6:31 ` [PATCH v4 6/9] bus: mhi: Load DDR training data using per-device serial number Kishore Batta
2026-03-21 18:44 ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 [PATCH v2 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-07 11:41 ` [PATCH v2 6/9] bus: mhi: Load DDR training data using per-device serial number Kishore Batta
2026-03-08 22:09 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260310-sahara_protocol_new_v2-v3-6-994ea4b0d5ad@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox