From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Load DDR training data using per-device serial number Date: Wed, 11 Mar 2026 13:35:23 +1000 Message-ID: In-Reply-To: <20260310-sahara_protocol_new_v2-v3-6-994ea4b0d5ad@oss.qualcomm.com> References: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> <20260310-sahara_protocol_new_v2-v3-6-994ea4b0d5ad@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds per-serial-number DDR training image lookup. **Issues:** - **Missing `active_image_id` assignment in the DDR serial-number success path.** When the serial-number firmware load succeeds (line 532-533 in the final file), the code falls through but `context->active_image_id = image_id;` is set at line 559 (after the else block). Looking carefully, the DDR serial success path does NOT return early, so it will reach line 559. However, the else branch at line 544 returns on failure but reaches line 559 on success. This is correct but the flow is confusing and would benefit from restructuring. - The pre-existing comment `"Suppress error messages that could suggest an a problem"` has a typo: "an a problem" should be "a problem". --- Generated by Claude Code Patch Reviewer