From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: tc358768: Separate video format config Date: Thu, 12 Mar 2026 07:14:50 +1000 Message-ID: In-Reply-To: <20260311-tc358768-v2-6-e75a99131bd5@ideasonboard.com> References: <20260311-tc358768-v2-0-e75a99131bd5@ideasonboard.com> <20260311-tc358768-v2-6-e75a99131bd5@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves `TC358768_DATAFMT` and `TC358768_DSITX_DT` register writes from `pre_enable()` to a new `tc358768_config_video_format()` function called from `enable()`. This is a prerequisite for patch 7, which needs to write these same registers with different values for long command transmission during the pre_enable/enable window. The `default` case in the new function calls `return` without setting `priv->error`, unlike the original code path in `pre_enable()` which had a goto to handle the error. However, the function does call `dev_err()`, and the missing format would already have been caught during the `hact` computation in `pre_enable()` (which retains the `default` case with the `goto err` path). So the video format function's default case is effectively unreachable. Acceptable. --- Generated by Claude Code Patch Reviewer