From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: mm: Add support to use PRAMIN windows to write to VRAM Date: Wed, 01 Apr 2026 07:33:00 +1000 Message-ID: In-Reply-To: <20260311004008.2208806-7-joelagnelf@nvidia.com> References: <20260311004008.2208806-1-joelagnelf@nvidia.com> <20260311004008.2208806-7-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `VramAddress`, `VirtualAddress`, `Pfn`, `Vfn` newtypes with bitfield layouts. The type design is clean. **Observation:** Both `VramAddress` and `VirtualAddress` have a `raw()` method returning `usize` (via `u64_as_usize`). On 32-bit platforms this could truncate. However, nova-core targets 64-bit only, so this is fine in practice. **Nit:** `VramAddress` manually implements `PartialEq`, `Eq`, `PartialOrd`, `Ord` on the inner `u64`, but these could potentially be derived if the bitfield macro supports it. Not blocking. --- Generated by Claude Code Patch Reviewer