From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Date: Sun, 22 Mar 2026 05:00:33 +1000 Message-ID: In-Reply-To: <20260318-rimob-new-features-v2-6-c1bf8917449e@protonmail.com> References: <20260318-rimob-new-features-v2-0-c1bf8917449e@protonmail.com> <20260318-rimob-new-features-v2-6-c1bf8917449e@protonmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds a Hall effect sensor as a `gpio-keys` switch mapped to `SW_LID`. **Minor: `bias-disable` for Hall sensor pinctrl** ```dts gpio_hall_sensor_default: gpio-hall-sensor-default-state { pins = "gpio46"; function = "gpio"; drive-strength = <2>; bias-disable; }; ``` Some Hall sensor configurations use `bias-pull-up` to ensure a defined state when the magnet is absent. `bias-disable` means the pin floats when undriven, which could cause spurious events. However, if the hardware has an external pull-up, this is fine. Just worth verifying. No other issues. The squashing of Hall sensor into the existing `gpio-keys` node (as requested in v1 review) is done correctly. **Summary of required fixes:** 1. **Patch 2**: Use `mipi_dsi_dcs_exit_sleep_mode_multi()` and `mipi_dsi_dcs_set_display_on_multi()` instead of `mipi_dsi_generic_write_seq_multi()` for the DCS sleep-out and display-on commands. 2. **Patch 1**: Consider removing `vddam-supply` from the binding if it's not used, or add it to the driver if the hardware needs it. --- Generated by Claude Code Patch Reviewer