From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Load DDR training data using per-device serial number Date: Sun, 22 Mar 2026 04:44:34 +1000 Message-ID: In-Reply-To: <20260319-sahara_protocol_new_v2-v4-6-47ad79308762@oss.qualcomm.com> References: <20260319-sahara_protocol_new_v2-v4-0-47ad79308762@oss.qualcomm.com> <20260319-sahara_protocol_new_v2-v4-6-47ad79308762@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds special-case handling for image_id 34 to load per-serial DDR training = files. **Issues:** - **No validation that `serial_number` is non-zero**. If the serial number = is 0 (uninitialized), the code tries to load `mdmddr_0x0.mbn`, which is mea= ningless. Should check and skip directly to the table fallback. - **Existing typo preserved**: `"suggest an a problem"` at `sahara.c:547` = =E2=80=94 should be `"suggest a problem"`. While pre-existing, this patch t= ouches the surrounding code. - **Code duplication** between the DDR special-case fallback and the normal= path =E2=80=94 both have identical `sahara_request_fw()` + error logging s= equences. --- Generated by Claude Code Patch Reviewer